Skip to content

[pulsar-proxy] Fix memory leak with debug log-level - #7963

Merged
merlimat merged 1 commit into
apache:masterfrom
rdhabalia:proxy_leak2
Oct 29, 2020
Merged

[pulsar-proxy] Fix memory leak with debug log-level#7963
merlimat merged 1 commit into
apache:masterfrom
rdhabalia:proxy_leak2

Conversation

@rdhabalia

@rdhabalia rdhabalia commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Motivation

Right now, Proxy has memory leak debug log-level=2 because proxy parses RawMessage and doesn't release the payload. It can be easily and quickly reproducible by enabling proxyLogLevel=2 and publish messages across 10 topics.

#2:
	io.netty.buffer.AdvancedLeakAwareByteBuf.readByte(AdvancedLeakAwareByteBuf.java:400)
	org.apache.pulsar.common.util.protobuf.ByteBufCodedInputStream.readRawVarint64(ByteBufCodedInputStream.java:251)
	org.apache.pulsar.common.util.protobuf.ByteBufCodedInputStream.readUInt64(ByteBufCodedInputStream.java:218)
	org.apache.pulsar.common.api.proto.PulsarApi$MessageMetadata$Builder.mergeFrom(PulsarApi.java:4067)
	org.apache.pulsar.common.protocol.Commands.parseMessageMetadata(Commands.java:378)
	org.apache.pulsar.common.api.raw.MessageParser.parseMessage(MessageParser.java:65)
	org.apache.pulsar.proxy.server.ParserProxyHandler.channelRead(ParserProxyHandler.java:126)
	io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
	io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
	io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
	io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:323)
	io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:297)
	io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
	io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
	io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340)
	io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1434)
	io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
	io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
	io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:965)
	io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163)
	io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:648)
	io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:583)
	io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:500)
	io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:462)
	io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:897)
	io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	java.lang.Thread.run(Thread.java:745)

Modification

Release RawMessage payload to avoud memory leak.

@rdhabalia rdhabalia added this to the 2.7.0 milestone Sep 3, 2020
@rdhabalia rdhabalia self-assigned this Sep 3, 2020
@rdhabalia

rdhabalia commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@merlimat
merlimat merged commit bd4e9ba into apache:master Oct 29, 2020
@rdhabalia
rdhabalia deleted the proxy_leak2 branch October 29, 2020 18:45
@merlimat merlimat mentioned this pull request Oct 29, 2020
Closed
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
@rdhabalia @huangdx0726
[pulsar-proxy] Fix memory leak with debug log-level (apache#7963)
ce3d9da
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
@rdhabalia @flowchartsman
[pulsar-proxy] Fix memory leak with debug log-level (apache#7963)
9225a2d
@zymap zymap mentioned this pull request Nov 19, 2020
Closed
@sijie sijie mentioned this pull request Nov 19, 2020
Closed
@nsalwan nsalwan mentioned this pull request Jan 21, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes
@codelipenghui codelipenghui Awaiting requested review from codelipenghui
@jiazhai jiazhai Awaiting requested review from jiazhai
@sijie sijie Awaiting requested review from sijie

Assignees

@rdhabalia rdhabalia

Labels

area/proxy

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdhabalia @merlimat